[Buildroot] [PATCH v4 1/1] package/libssh2: Add selectable crypto libraries

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

Hi,

 >> >  This does affect people updating Buildroot, so it needs to be mentioned in CHANGES.
 >> 
 >> Why don't we just keep the old logic instead? E.G. leave the select
 >> openssl if !(mbedtls || libgcrypt) and then change the selects to
 >> depends on in the choice:
 >> 
 >> choice
 >> 
 >> config BR2_PACKAGE_LIBSSH2_MBEDTLS
 >> bool "mbedtls"
 >> depends on BR2_PACKAGE_MBEDTLS
 >> 
 >> ...
 >> 
 >> Doesn't that give us the best of both worlds? Same behaviour as before
 >> by default and still the option to explicitly chose when multiple
 >> backends are available?

 > That's what Sam did in the initial iterations of his patchset, but
 > Arnout and Thomas (IIRC) both requested he replaces that with a select
 > instead.

Hmm, I could only find Arnouts mail asking to use select, but he didn't
write why. Arnout, why not use depends on here?

-- 
Bye, Peter Korsgaard