[Buildroot] BR2_REPRODUCIBLE issues
Peter Korsgaard
peter at korsgaard.com
Sat Nov 4 20:49:01 UTC 2017
>>>>> "Arnout" == Arnout Vandecappelle <arnout at mind.be> writes:
Hi,
>> This is with current master and make 4.1.
> But not when there is no .config file:
> $ make O=/tmp/brtest BR2_REPRODUCIBLE=y printvars VARS=SOURCE_DATE_EPOCH
> /bin/sh: log: command not found
> SOURCE_DATE_EPOCH=
> /bin/sh: log: command not found
No, but that makes sense as there isn't a BR2_GIT setting, so moving the
assignment around won't fix that.
Having the SOURCE_DATE_EPOCH assignment fail when you don't have a
.config (and hence also no BR2_REPRODUCIBLE=y) is imho not a big deal.
> Solution: move the GIT definition to top-level Makefile.
Sorry, what does that fix? GIT comes from BR2_GIT, E.G. the .config.
>> So I don't really agree that it useless. What we could perhaps do is to
>> only export our value for SOURCE_DATE_EPOCH if not already set in the
>> enviroment, so you can set it outside Buildroot if you want a different
>> behaviour.
> Well, the proposed solution of using a config variable sounds OK. Only, I think
> it would make more sense to have a config variable with a date, rather than a
> commit ID.
Agreed, or simply only set SOURCE_DATE_EPOCH if it isn't already set in
the environment which imho is a more generic solution.
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list