[Buildroot] [PATCH 3/3] support/testing: simplify logging by keeping the log file open
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Wed May 17 20:00:06 UTC 2017
Hello,
On Wed, 10 May 2017 23:33:46 +0200, Luca Ceresoli wrote:
> We currently call infra.smart_open() to open log files each time we
> need to write to them.
>
> Opening the file once in the constructor of Builder and Emulator and
> writing to it whenever needed is simpler and slightly more efficient.
>
> Remove smart_open and instead create a new open_log_file() function
> which just opens the logfile. Also let it compute the filename, in
> order to simplify even further the Builder and Emulator code.
>
> Signed-off-by: Luca Ceresoli <luca at lucaceresoli.net>
> ---
> support/testing/infra/__init__.py | 21 +++++++--------------
> support/testing/infra/builder.py | 12 +++---------
> support/testing/infra/emulator.py | 15 +++++----------
> 3 files changed, 15 insertions(+), 33 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
More information about the buildroot
mailing list