[Buildroot] [PATCH v2 2/4] core: allow check-host-cmake.sh to try several candidates

Carlos Santos casantos at datacom.ind.br
Mon May 8 17:14:07 UTC 2017


> From: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> To: "Carlos Santos" <casantos at datacom.ind.br>
> Cc: buildroot at buildroot.org
> Sent: Sunday, May 7, 2017 1:11:32 PM
> Subject: Re: [PATCH v2 2/4] core: allow check-host-cmake.sh to try several candidates

>>     $ sh check-host-cmake.sh 3.1 python
>>     Python 2.7.12
>>     check-host-cmake.sh: 35: [: -gt: unexpected operator
>>     check-host-cmake.sh: 38: [: -eq: unexpected operator
> 
> Well, this can only happen in one condition: the 'cmake' (or 'cmake3')
> executable is in fact not CMake, which would be an excessively stupid
> situation...
---8<---
> 
> I'm not against having a stricter regex, but remember what you are
> trying to protect against... And I personally don't think the cases you
> point at would ever happen, unless one of the candidates is in fact not
> CMake.

OK, let's keep the paranoia at its current level. :-)

-- 
Carlos Santos (Casantos) - DATACOM, P&D
“The greatest triumph that modern PR can offer is the transcendent 
success of having your words and actions judged by your reputation, 
rather than the other way about.” — Christopher Hitchens


More information about the buildroot mailing list