[Buildroot] [PATCH] package/protobuf: needs gcc >= 4.5

[Romain Naour]

Hi Thomas,

Le 07/05/2017 à 15:20, Thomas Petazzoni a écrit :
> Hello,
> 
> On Sun,  7 May 2017 15:16:52 +0200, Romain Naour wrote:
> 
>> diff --git a/package/protobuf-c/Config.in b/package/protobuf-c/Config.in
>> index a32e6cd..6f916c5 100644
>> --- a/package/protobuf-c/Config.in
>> +++ b/package/protobuf-c/Config.in
>> @@ -4,12 +4,14 @@ config BR2_PACKAGE_PROTOBUF_C
>>  	depends on BR2_TOOLCHAIN_HAS_THREADS
>>  	# host-protobuf only builds on certain architectures
>>  	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
>> +	depends on BR2_HOST_GCC_AT_LEAST_4_5 # host-protobuf
> 
> You're adding a new dependency to protobuf-c, but protobuf-c is also
> selected by a few packages:
> 
> package/collectd/Config.in:     select BR2_PACKAGE_PROTOBUF_C
> package/riemann-c-client/Config.in:     select BR2_PACKAGE_PROTOBUF_C
> 
> You also need to propagate the dependency to these packages.
> 
> Generally speaking, when propagating new dependencies, you should not
> only take care of first level reverse dependencies, but also
> recursively take care of all reverse dependencies.

Thanks, fixed in v2.

Best regards,
Romain

> 
> Thomas
>