[Buildroot] [PATCH 15/21] freeswitch: use SPDX short identifier for license strings
Rahul Bedarkar
rahulbedarkar89 at gmail.com
Fri Mar 31 17:37:05 UTC 2017
Hello,
On Fri, Mar 31, 2017 at 3:49 AM, Arnout Vandecappelle <arnout at mind.be> wrote:
>
>
> On 30-03-17 15:43, Rahul Bedarkar wrote:
>> Signed-off-by: Rahul Bedarkar <rahulbedarkar89 at gmail.com>
>
> Quick comment on this one...
>
> First of all, I think it's a very good idea to have first the fully automatic
> patches, and then do remaining fixups like this one.
>
> However, I think there is still a lot more to be fixed up. There are also
> plenty of places where we refer to (L)GPLv[23] in e.g. comments. So instead of
> this patch, I would add a series of patches that uses the same (or maybe
> slightly more generic) sed expressions but now doesn't limit to _LICENSE or to
> .mk files. I did a quick check, there are about 25 instances of GPLv left, but
> you need to filter out patches and _LICENSE_FILES, so perhaps an automatic sed
> expression is going to be difficult.
>
> Anyway, my message is: those 25 remaining instances should be replaced as well.
I was not sure if license strings in comments should be updated to use
SPDX identifier.
May be for consistency it should be ? But it doesn't harm either, so I
will fix those
separately with this one.
Thanks,
Rahul
More information about the buildroot
mailing list