[Buildroot] [v5] package: add qt5virtualkeyboard

Gaël PORTAY gael.portay at savoirfairelinux.com
Wed Mar 29 16:03:38 UTC 2017


Hello Thomas,

On Wed, Mar 29, 2017 at 06:00:16PM +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed, 29 Mar 2017 11:58:22 -0400, Gaël PORTAY wrote:
> 
> > Changes since v4:
> >  - Prefix local variables to avoid potential naming collisions.
> 
> You forgot one.
> 
> 
> > +QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS = $(call qstrip,$(BR2_PACKAGE_QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> > +QT5VIRTUALKEYBOARD_ALL_LAYOUTS = $(findstring all,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS))
> > +ifneq ($(strip $(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS)),)
> > +QMAKEFLAGS += CONFIG+="$(foreach lang,$(QT5VIRTUALKEYBOARD_LANGUAGE_LAYOUTS),lang-$(lang))"
> 
> QMAKEFLAGS is still not properly prefixed.
> 

Indeed, sorry for this missing one.

> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Let me resend a new patch...

Regards,
Gael


More information about the buildroot mailing list