[Buildroot] [PATCH v2 2/2] Makefile: add check of binaries architecture

Arnout Vandecappelle arnout at mind.be
Sun Mar 12 21:34:04 UTC 2017


 I forgot to mention this:

> +    # Get architecture using readelf
> +    farchname=$(${TARGET_CROSS}readelf -h ${f} | \

 Since this is the only use of TARGET_CROSS, it would make more sense to pass
TARGET_READELF.

 We could even use the host readelf, except I'm not sure that older readelf
binaries know about newish architectures like ARC. Trying with an old 2.20
binary... Right, it *can* read an ARC file, but it reports
  Machine:                           <unknown>: 0xc3

 So, pass TARGET_READELF.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list