[Buildroot] [PATCH 1/1] test-pkg: Extend the logfile with the first command as well

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Mar 9 22:02:05 UTC 2017


Hello,

On Thu, 9 Mar 2017 23:00:44 +0100, Yann E. MORIN wrote:

> > > -    if ! make O="${dir}" olddefconfig >/dev/null 2>&1; then
> > > +    if ! make O="${dir}" olddefconfig > "${dir}/logfile" 2>&1; then  
> > 
> > To be honest, I wasn't sure if we wanted > or >> here. It matters if
> > you restart the test-pkg command after fixing issues. Do you want
> > logfiles to contain the log of all previous builds, or just the current
> > build?
> > 
> > For now, I've applied your patch as-is, with just ">", which means the
> > logfile will only contain the output of the last build. It seems better
> > to me this way, but we'll see if other folks disagree.  
> 
> Using append-redirection is what we should have used here, because the
> logfile is already created a few lines above, for olddefconfig.

Hu? We're precisely changing the olddefconfig line in this patch. Am I
missing something?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list