[Buildroot] [PATCH] package/alsamixergui: add license information

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Thu Mar 2 20:37:41 UTC 2017


Hello,

Please keep the Buildroot mailing list in Cc. Thanks!

On Thu, 2 Mar 2017 18:28:08 +0100, Wolfgang Grandegger wrote:

> "make legal-info" did report that the license is unkown.

Yes, before your patch. What I suggested is that you should run "make
legal-info" after your patch.

> Then I looked
> into "build/alsamixergui...". The COPYING file seems to be generated by make:
> 
> $ make alsamixergui-dirclean
> $ make alsamixergui-extract
> $ head build/alsamixergui-0.9.0rc2-1/COPYING 
> head: cannot open 'build/alsamixergui/COPYING' for reading: No such file or directory
> $ make alsamixergui
> $ head build/alsamixergui-0.9.0rc2-1/COPYING 

OK, but that doesn't work, because you have no guarantee that the
package has been built when "make legal-info" runs. "make legal-info"
only ensures that packages have been: 1. downloaded, 2. extracted, 3.
patched.

So, with your patch applied, if you run:

 $ make clean
 $ make legal-info

then you will see that it fails, because the COPYING file doesn't exist.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list