[Buildroot] [PATCH 4/5] support/testing: add package tests

[Ricardo Martincoski]

Thomas,

On Tue, Feb 07, 2017 at 09:36 AM, Thomas Petazzoni wrote:

[snip]
> +++ b/support/testing/tests/package/test_dropbear.py
[snip]
> +        cmd = "netstat -ltn 2>/dev/null | grep -q 0.0.0.0:22"

You could drop the '-q' here.
Since the log is sent to a file it will not bother the user.
And when a testcase fails a verbose log helps to locate the problem.

Also it will be consistent to the use of 'grep' in all other testcases.

[snip]
> +++ b/support/testing/tests/package/test_python.py
[snip]
> +        cmd = "python --version 2>&1 | grep -q '^Python 2'"
[snip]

Same here.

Regards,
Ricardo