[Buildroot] [PATCH 0/5] package/cmake: re-introduce cmake-3.7

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Mar 1 07:59:28 UTC 2017


Hello,

On Wed, 1 Mar 2017 08:49:47 +0100, Arnout Vandecappelle wrote:

>  I don't think it makes much sense to keep the 4 separate patches. The history
> shows the authorship of the original bump. Having the 4 separate patches just
> adds noise to the history. Also, Thomas reported that the libuv dependency
> introduced by the bump is probably incorrect, so we'd have to revert patch 4/5
> and part of patch 2/5 again later on... And if the dependency on libuv *is*
> needed, then you re-introduce a non-bisectable commit between patch 2/5 and 4/5.

Well, the libuv dependency is incorrect in the sense that ctest doesn't
seem to use libuv.

*However*, the libuv dependency is correct in the sense that the
CMakeLists.txt checks it, and if not, builds the cmake built-in version
of libuv. But since for the target we only build ctest, this whole
libuv is not used.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list