[Buildroot] [PATCH 1/5] support/check-package: don't check filenames of hashes

Ricardo Martincoski ricardo.martincoski at gmail.com
Mon Jun 26 03:34:42 UTC 2017


Hello,

On Sun, Jun 25, 2017 at 07:03 PM, Yann E. MORIN wrote:

> Currently, we check that the filenames in hash lists do not contain
> a slash '/' character, because all we are checking so far are the
> downloaded archives, and we explicitly need the filename to not contain
> a directory component at all.
> 
> However, we're soon to also check the hashes of the license files in
> packages sources, and those license files may be at any arbitrary
> directory-depth in the packages source tree, and thus two or more

Small nit: the explanation could end at "source tree". The removed code was
testing only for the presence of a slash, so having 2 entries with the same
basename shouldn't matter.

> license files may have the same basename.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

Either with the nit fixed or not,
Acked-by: Ricardo Martincoski <ricardo.martincoski at gmail.com>

Regards,
Ricardo


More information about the buildroot mailing list