[Buildroot] [PATCH v4 2/6] board: engicam: Rename defconfig engicam_imx6qdl_icore_mmc_defconfig

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Mon Jun 19 20:19:27 UTC 2017


Hello,

On Mon, 19 Jun 2017 12:57:28 +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan at amarulasolutions.com>
> 
> Since the board have support for nand, better to explicitly
> name it with mmc.
> 
> engicam_imx6qdl_icore_defconfig => engicam_imx6qdl_icore_mmc_defconfig
> 
> Signed-off-by: Jagan Teki <jagan at amarulasolutions.com>

Unless we are going to introduce other configurations for the same
board (to support NAND booting), then I would prefer to keep the name
without the "mmc". The readme.txt can explain that the configuration
supports MMC booting.

Also, in the follow-up patches, please avoid the _mmc_ part in the
defconfig name.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list