[Buildroot] [PATCH v2] new package: ratpoison

Mario Rugiero mrugiero at gmail.com
Tue Jun 6 23:02:11 UTC 2017


2017-06-06 18:01 GMT-03:00 Thomas Petazzoni
<thomas.petazzoni at free-electrons.com>:
> Hello,
Hello.
>
> I've applied, after doing a number of fixes.
>
> First, the commit title should have been "ratpoison: new package".
Noted.
>
> On Thu,  1 Jun 2017 11:33:49 -0300, Mario J. Rugiero wrote:
>> diff --git a/package/ratpoison/ratpoison.mk b/package/ratpoison/ratpoison.mk
>> new file mode 100644
>> index 000000000..18222c217
>> --- /dev/null
>> +++ b/package/ratpoison/ratpoison.mk
>> @@ -0,0 +1,25 @@
>> +################################################################################
>> +#
>> +# ratpoison
>> +#
>> +################################################################################
>> +
>> +RATPOISON_VERSION = 1.4.9
>> +RATPOISON_SOURCE = ratpoison-$(RATPOISON_VERSION).tar.xz
>> +RATPOISON_SITE = http://download.savannah.nongnu.org/releases/ratpoison
>> +RATPOISON_LICENSE = GPL-2.0
>
> The license really was GPL-2.0+, not GPL-2.0.
It didn't seem like it was GPL-2.0+ in the COPYING file, but I may be wrong.
>
>> +RATPOISON_LICENSE_FILES = COPYING
>> +
>> +RATPOISON_CONF_OPTS = --x-includes=$(STAGING_DIR)/usr/include/X11 \
>> +                   --x-libraries=$(STAGING_DIR)/usr/lib
>
> Indentation on the second line should be done with just one tab. And
> also, explicitly disabling options not handled is a good practice. So
> in the end, this looked like this:
>
> +RATPOISON_CONF_OPTS = \
> +       --x-includes=$(STAGING_DIR)/usr/include/X11 \
> +       --x-libraries=$(STAGING_DIR)/usr/lib \
> +       --without-xkb \
> +       --without-xft
Noted.
>
> If you want to send another patch to optionally enable XKB and XFT
> support, that would be welcome.
I'll probably send a new patch during this week.
>
>> +ifeq ($(BR2_PACKAGE_XLIB_LIBXRANDR),y)
>> +     RATPOISON_DEPENDENCIES += xlib_libXrandr
>> +     RATPOISON_CONF_OPTS += --with-xrandr
>
> Do not indent such variable definitions.
Noted
>
> Applied with those fixes. Thanks!
>
> Thomas
Thanks for the feedback.
Mario.
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com


More information about the buildroot mailing list