[Buildroot] [PATCH 2/2] package/ffmpeg: fix static linking with alsa
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon Jun 5 12:48:12 UTC 2017
Hello,
On Thu, 1 Jun 2017 22:39:30 +0200, Bernd Kuhls wrote:
> If BR2_PACKAGE_ALSA_LIB_RAWMIDI is enabled ffmpeg needs also
> BR2_PACKAGE_ALSA_LIB_SEQ to link against alsa.
>
> A similar patch was committed to alsa-utils:
> https://git.buildroot.net/buildroot/commit/package/alsa-utils?id=c69088b8c35177cecdd0f1f385c13f5b2c509f1d
>
> Fixes
> http://autobuild.buildroot.net/results/7ba/7ba485532fcab74928246a8f95dba7e5eea9d4a5/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls at t-online.de>
I think this is a bogus change, and that the commit
c69088b8c35177cecdd0f1f385c13f5b2c509f1d from Peter is equally bogus.
Indeed, src/rawmidi/Makefile.am contains:
librawmidi_la_SOURCES = rawmidi.c rawmidi_hw.c rawmidi_symbols.c
if BUILD_SEQ
librawmidi_la_SOURCES += rawmidi_virt.c
endif
So the rawmidi_virt.c code is not compiled in when --disable-seq is
passed. So, IMO, instead of forcing seq support, we should instead
adjust src/rawmidi/rawmidi_symbols.c as-is:
static const char **snd_rawmidi_open_objects[] = {
&_snd_module_rawmidi_hw,
#ifdef BUILD_SEQ
&_snd_module_rawmidi_virt
#endif
};
And I believe this patch would be upstreamable. Peter, what do you
think?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list