[Buildroot] [PATCH] linux: Fix URL for release candidate versions

Baruch Siach baruch at tkos.co.il
Tue Jul 25 20:21:31 UTC 2017


Hi Luis,

On Tue, Jul 25, 2017 at 10:28:48AM -0400, Luis Araneda wrote:
> On Tue, Jul 25, 2017 at 4:37 AM, Baruch Siach <baruch at tkos.co.il> wrote:
> > On Mon, Jul 24, 2017 at 11:14:01PM -0400, Luis Araneda wrote:
> >> Starting with 4.12-rc1, tarballs are generated by cgit
> >> directly from Linus's tree.
> >> This method also applies to older release candidates.
> >>
> >> Signed-off-by: Luis Araneda <luaraneda at gmail.com>
> >> ---
> >>  linux/linux.mk | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/linux/linux.mk b/linux/linux.mk
> >> index 032d64fc2..e8b779f7e 100644
> >> --- a/linux/linux.mk
> >> +++ b/linux/linux.mk
> >> @@ -43,9 +43,10 @@ LINUX_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/v3.x
> >>  else ifeq ($(findstring x4.,x$(LINUX_VERSION)),x4.)
> >>  LINUX_SITE = $(BR2_KERNEL_MIRROR)/linux/kernel/v4.x
> >>  endif
> >> -# release candidates are in testing/ subdir
> >> +# Release candidates tarballs are generated automatically from a git tag
> >>  ifneq ($(findstring -rc,$(LINUX_VERSION)),)
> >> -LINUX_SITE := $(LINUX_SITE)/testing
> >> +LINUX_SITE := https://git.kernel.org/torvalds/t
> >> +LINUX_SOURCE = linux-$(LINUX_VERSION).tar.gz
> >
> > Why do you need to add this? It should be the default value.
> >
> >>  endif # -rc
> >>  endif
> 
> I didn't fully understand what you mean, but I will try to answer the ones

What I meant to say is that <PKG>_SOURCE defaults to 
<pkg>-$(<PKG>_VERSION).tar.gz (see package/pkg-generic.mk). So the 
LINUX_SOURCE assignment seems to be redundant.

> - We can change LINUX_SOURCE to always be a .tar.gz file. The official Mirrors
>   have both .tar.xz and .tar.gz files. But a .tar.xz file is
> approximately 33% smaller than the
>   corresponding tar.gz. If this is not a problem, I can send a v2
> changing the default to .tar.gz
> 
> - With this approach, we can download even stable Kernels, but we
> would be adding more load
>   to the servers, as the files are generated internally using git
> archive. At least that's what
>   I understood when reading [1]. We would also lose the signature verification,
>   should anyone be interested in that in the future.
> 
> [1] https://www.kernel.org/rc-tarballs-and-patches-starting-with-412-rc1.html

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -


More information about the buildroot mailing list