[Buildroot] [PATCH 07/20] system: move remounting / to the corresponding init systems

Arnout Vandecappelle arnout at mind.be
Sat Jul 22 13:16:42 UTC 2017



On 18-07-17 19:25, Yann E. MORIN wrote:
> Currently, remounting / read-write (or not) is done by the skeleton
> package when the init system is eitehr busybox or sysvinit, by
                                  either
> registering a target-finalize hook; it is not done at all for systemd.
> 
> Move registering this target-finalize hook to both of busybox and
> sysvinit. Leave systemd alone, we'll take care of it later.
> 
> Rename the macro to a more meaningful name, and move it to system.mk
> with the other such macros.
> 
> Yet a little bit less init-system knowledge in the skeleton.
> 
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>

 Small details to fix...

[snip]
> +# Provided by the skeleton package

 Not really, it's provided by system.mk - which is kind of obvious from the
name. So I'd just remove this comment.

> +BUSYBOX_TARGET_FINALIZE_HOOKS += SYSTEM_REMOUNT_ROOT_INITTAB

 Excellent choice in variable name!

[snip]
> +# Provided by the skeleton package

 Same here of course.

> +SYSVINIT_TARGET_FINALIZE_HOOKS += SYSTEM_REMOUNT_ROOT_INITTAB
> +
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list