[Buildroot] [PATCH 1/1] Add option to the gst1-plugins-bad package to enable/disable the qt plugin.
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Jul 21 09:22:25 UTC 2017
Hello,
On Fri, 21 Jul 2017 17:13:07 +0800, Glenn Coombs wrote:
> +config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_QT
> + bool "qt"
Don't you need Qt to be built for this plugin to be compiled?
I would expect some "depends on" on Qt here.
Also, what about qt4 vs. qt5 ?
> +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_QT),y)
> +GST1_PLUGINS_BAD_CONF_OPTS += --enable-qt
I would expect a GST1_PLUGINS_BAD_DEPENDENCIES += statement here, to
make sure qt or qt5 get built before GStreamer.
Or is Qt not needed to built GStreamer Qt support ?
Also, we have to be careful, because qt5base itself can depend on
gst1-plugins-base, so we need to be careful to not introduce a circular
dependency.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list