[Buildroot] [PATCH v7 2/9] support/scripts: add fix-rpath script to sanitize the rpath
Wolfgang Grandegger
wg at grandegger.com
Thu Jul 20 16:50:41 UTC 2017
Am 20.07.2017 um 16:19 schrieb Arnout Vandecappelle:
>
>
> On 20-07-17 16:08, Wolfgang Grandegger wrote:
>> Hello Arnout,
>>
>> Am 20.07.2017 um 15:45 schrieb Arnout Vandecappelle:
>>>
>>>
>>> On 20-07-17 11:03, Wolfgang Grandegger wrote:
>>>> case "${tree}" in
>>>> host)
>>>> ...
>>>> # we always want $ORIGIN-based rpaths to make it relocatable.
>>>
>>> Perfect. Just please start the sentence with a capital (it ends with a .)
>>
>> Well, I followed the style of the original script... just to be consistent...
>> otherwise we will have an ugly mix.
>
> There is no original script, only an original author :-)
I have no problem to adapt the style of the original author(s) ;). It
should just be consistent.
> So indeed, fix it script-wide please.
>
> [snip]
>>>> As I said, the execution time comes form scanning for ELF files. The rest
>>>> doesn't
>>>> matter a lot.
>>>
>>> Instead of the patch you attached, it might actually make more sense to create
>>> a tiny C file that does this, and execute that as part of the find command. Or
>>> you could just create support/scripts/elfmagic with those 4 bytes and use "cmp
>>> -n 4 {} ${0%/*}/elfmagic".
>>
>> Yes, I had that idea as well and I have already hacked something. The problem is
>> that it does not check if it does have an rpath.
>
> Well, you could do that particular check in the find -exec and keep the
> --print-rpath check in the while loop.
>
>
>> "cmp" is not faster, I already
>> tried!
>
> OK good. Might be a good idea to keep track of the things you already tried in
> the cover letter.
Well, it's already a few month ago that I tried finding a good and fast
solution. I tried a lot of things, be can't remember the details. My
time working on this topic is limited! When I have more free time I will
take care.
Wolfgang.
More information about the buildroot
mailing list