[Buildroot] [PATCH 1/2] arch/mips: improve help text of NaN option

Vicente Olivert Riera Vincent.Riera at imgtec.com
Mon Jul 17 16:57:22 UTC 2017


Hi Thomas,

On 17/07/17 13:56, Thomas Petazzoni wrote:
> Hello,
> 
> On Mon, 17 Jul 2017 13:22:54 +0100, Vicente Olivert Riera wrote:
> 
>> diff --git a/arch/Config.in.mips b/arch/Config.in.mips
>> index 7dd69659d..f2b352b0b 100644
>> --- a/arch/Config.in.mips
>> +++ b/arch/Config.in.mips
>> @@ -169,7 +169,9 @@ choice
>>  	depends on BR2_mips_32r5 || BR2_mips_64r5
>>  	default BR2_MIPS_ENABLE_NAN_2008
>>  	help
>> -	  NaN encoding to be used
>> +	  MIPS supports two different NaN encodings, legacy and 2008.
>> +	  Information about MIPS NaN encodings can be found here:
>> +	  https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
> 
> Is it useful (and correct?) to say that the Linux kernel, built for
> MIPS32r5, by default expect the 2008 NaN encoding?

It is correct, but since nan2008 is the default I think is not worth
mentioning it. If you change the default value is because you know what
you are doing, right?

Vincent

> 
> Thomas
> 


More information about the buildroot mailing list