[Buildroot] [PATCH 1/1] sngrep: remove ncurses wchar support

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jul 15 21:15:49 UTC 2017


Hello,

On Fri, 14 Jul 2017 11:38:35 -0400, Adam Duskett wrote:
> sngrep currently doesn't really use wchar support anyways, and when
> checking for wchar support, it's checking the host systems ncurses
> libraries.
> 
> Remove support for ncurses wchar until it's used in sngrep, and remove
> the patches used to fix ncurses wchar detection.
> 
> Signed-off-by: Adam Duskett <aduskett at gmail.com>
> ---
>  ...001-autotools-fix-ncurses-wchar-detection.patch | 158 ---------------------
>  ...002-autotools-fix-ncurses-wchar-detection.patch |  45 ------
>  package/sngrep/sngrep.mk                           |   4 -
>  3 files changed, 207 deletions(-)
>  delete mode 100644 package/sngrep/0001-autotools-fix-ncurses-wchar-detection.patch
>  delete mode 100644 package/sngrep/0002-autotools-fix-ncurses-wchar-detection.patch

I found out it was possible to fix the build issues by passing the
appropriate
SNGREP_NCURSESxyz_CONFIG_SCRIPT=$(STAGING_DIR)/usr/bin/ncursesxyz-config,
but since you say wchar isn't really used by sngrep anyway, I don't
think it's worth adding even more complexity, and I'm happy to see
patches being removed.

Therefore: applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list