[Buildroot] [PATCH v2 03/13] package/minetest: new package

[Romain Naour]

Hi Thomas,

Le 13/07/2017 à 10:24, Thomas Petazzoni a écrit :
> Hello,
> 
> On Wed, 12 Jul 2017 18:37:39 +0200, Romain Naour wrote:
> 
>> Le 24/06/2017 à 17:19, Thomas Petazzoni a écrit :
>>> Hello,
>>>
>>> On Mon, 12 Jun 2017 22:54:00 +0200, Romain Naour wrote:
>>>   
>>>> + 		message(STATUS "GetText enabled; locales found: ${GETTEXT_AVAILABLE_LOCALES}")
>>>> ++		# On some platforms, such as Linux with GNU libc, the gettext
>>>> ++		# functions are present in the C standard library and libintl
>>>> ++		# is not required. For other libc (uClibc-ng or musl) libintl  
>>>
>>> Only uClibc-ng in fact. musl has stub gettext functionality.  
>>
>> So, with your series applied during the summer camp this is not true even with
>> uClibc-ng.
> 
> Correct: now all C libraries provide some gettext implementation.

So this patch is not required anymore since gettext stub will be used.

> 
>> I think BR2_SYSTEM_ENABLE_NLS should be used in minetest.mk.
> 
> Why?

I mean BR2_SYSTEM_ENABLE_NLS should be used for gettext handling, see the
followup patch.

Best regards,
Romain

> 
> Thomas
>