[Buildroot] [PATCH 1/2] Makefile: don't rely on linux-tools being sorted alphabetically

Markus Mayer mmayer at broadcom.com
Mon Jul 10 03:49:27 UTC 2017


On 9 July 2017 at 05:41, Yann E. MORIN <yann.morin.1998 at free.fr> wrote:
> Arnout, All,
>
> On 2017-07-09 13:10 +0200, Arnout Vandecappelle spake thusly:
>> On 09-07-17 10:13, Yann E. MORIN wrote:
>> > Markus, All,
>> >
>> > On 2017-07-05 10:19 -0700, Markus Mayer spake thusly:
>> > [--SNIP--]
>> >> That said, and while I am a complete buildroot newbie, I do like the
>> >> suggestion of creating sub-directories for the tools and including the
>> >> makefiles from linux-tools.mk rather than relying on alphabetical
>> >> sorting.
>> >
>> > To be sure we're on the same line: one single sub-directory with all tools
>> > in there, not one sub-dir per tool.
>>
>>  Really? One sub-dir per tool would be more in-line with how we handle normal
>> packages.
>
> Well, I would find it a bit over-blown to have many sub-dirs with a
> single file (the .mk) in each.
>
> Unless you also expected that the big Config.in file be split too?
>
> I would argue against, because its fate is already a bit special: it is
> not sourced from package/Config.in but from linux/Config.in. and I would
> prefer we avoid a bit more complexity...

Yeah, I was wondering about that myself, actually. I do agree that
several directories containing only one file each don't seem all that
desirable. I'll see if I can get everything to work with just a single
sub-directory.

Regards,
-Markus


More information about the buildroot mailing list