[Buildroot] [PATCH 2/3] mtd: host variant needs host-util-linux, host-e2fsprogs

Arnout Vandecappelle arnout at mind.be
Thu Jul 6 22:52:52 UTC 2017



On 06-07-17 22:58, Thomas Petazzoni wrote:
> Since mtd was converted to the package infrastructure in commit
> de4cf4e9135e198d4c3beefc8ad63c03870eb78a ("mtd: convert to gentargets,
> add host package"), its host variant depended on host-e2fsprogs. At
> the time, only a host variant of the mtd package was available.
> 
> When a target variant of mtd was introduced in commit
> b50e0fa113bf641a3764ae99b94bb7ba4e1e8f85 ("mtd: add option to build
> mkfs.ubifs for target"), it depended on util-linux.
> 
> So today, the target variant continues to depend on util-linux, while
> the target variant depends on e2fsprogs. What mkfs.ubifs really needs
> is libuuid, which is provided by util-linux. It was in fact provided
> by the fact that host-e2fsprogs depends on host-util-linux.
> 
> But really, host-e2fsprogs is not needed as a dependency, so use
> host-util-linux to be consistent with the target variant.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>

 Excellent commit message!

 Regards,
 Arnout

> ---
>  package/mtd/mtd.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/mtd/mtd.mk b/package/mtd/mtd.mk
> index 043f1c7..3bac2d5 100644
> --- a/package/mtd/mtd.mk
> +++ b/package/mtd/mtd.mk
> @@ -44,7 +44,7 @@ else
>  MTD_CONF_OPTS += --without-xattr
>  endif
>  
> -HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-e2fsprogs
> +HOST_MTD_DEPENDENCIES = host-zlib host-lzo host-util-linux
>  HOST_MTD_CONF_OPTS = --disable-tests
>  
>  MKFS_JFFS2 = $(HOST_DIR)/sbin/mkfs.jffs2
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list