[Buildroot] [PATCH] libzip: depend on !BR2_STATIC_LIBS

[Arnout Vandecappelle]

On 04-07-17 12:48, Baruch Siach wrote:
> Hi Bartosz,
> 
> On Tue, Jul 04, 2017 at 12:24:09PM +0200, Bartosz Golaszewski wrote:
>> Since version 1.2.0 libzip requires dynamic library capabilities.
>>
>> Fixes: http://autobuild.buildroot.net/results/c50/c50ffa5bf565e75333192edc89e2d39044d07f26/
>> Signed-off-by: Bartosz Golaszewski <brgl at bgdev.pl>
>> ---
>>  package/libzip/Config.in | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/package/libzip/Config.in b/package/libzip/Config.in
>> index 54de9e5..0414186 100644
>> --- a/package/libzip/Config.in
>> +++ b/package/libzip/Config.in
>> @@ -1,8 +1,12 @@
>>  config BR2_PACKAGE_LIBZIP
>>  	bool "libzip"
>> +	depends on !BR2_STATIC_LIBS
> 
> You need to propagate dependencies to packages that select BR2_PACKAGE_LIBZIP, 
> and their reverse dependencies, recursively. In this case libsigrok, 
> sigrok-cli, and pulseview are affected.

 Also, we usually put the reason in a comment, in this case:

	depends on !BR2_STATIC_LIBS # dlsym()


 Regards,
 Arnout

> 
> baruch
> 
>>  	select BR2_PACKAGE_ZLIB
>>  	help
>>  	  C library for reading, creating, and modifying zip archives. This
>>  	  package also contains zipcmp, ziptorrent and zipmerge utilities.
>>  
>>  	  http://www.nih.at/libzip/
>> +
>> +comment "libzip needs a toolchain w/ dynamic library"
>> +	depends on BR2_STATIC_LIBS
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF