[Buildroot] [PATCH 2/5] core/pkg-generic: call MESSAGE when saving package legal-info

Peter Korsgaard peter at korsgaard.com
Mon Jul 3 15:59:07 UTC 2017


>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

 > Currently, the per-package legal-info is mostly silent, but we're soon
 > to add a check for the hashes of the license files.

 > In that case, and when there is a hash mis-match, we want a user to know
 > what package had a changed license file.

 > So, we add a call to MESSAGE to display the package we're currently
 > saving the legal-info of, like so:

 >>>> busybox 1.26.2 Collecting legal info

I wonder if we still need the general "Collecting legal info" message,
as it now looks something like:

>>>   Collecting legal info
>>> toolchain-buildroot  Collecting legal info
>>> host-gcc-final 6.3.0 Collecting legal info
>>> host-binutils 2.27 Collecting legal info
>>> host-gmp 6.1.2 Collecting legal info

Though, with the entire patch series applied it might be handy to match
the warnings, E.G.:

>>>   Collecting legal info
WARNING: no hash file for COPYING
>>> toolchain-buildroot  Collecting legal info

Presumably this warning is from legal-info-prepare. I'm not sure exactly
how we should get rid of this warning? A buildroot.hash with an entry
for our COPYING?

That can be fixed later though - Committed, thanks.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list