[Buildroot] [PATCH 3/4] toolchain-external: copy ld*.so* for all C libraries

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sun Jul 2 21:51:27 UTC 2017


Hello,

On Sun, 2 Jul 2017 21:21:46 +0200, Thomas De Schampheleire wrote:

> > diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > index 8460e37..c1c3900 100644
> > --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> > +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> > @@ -107,13 +107,11 @@ endif
> >  #
> >  # Definitions of the list of libraries that should be copied to the target.
> >  #
> > +
> > +TOOLCHAIN_EXTERNAL_LIBS += ld*.so*  
> 
> In copy_toolchain_sysroot, the patterns ld*.so and ld*.so.* are
> treated separately. I think the only reason must be to avoid matching
> ld*.something (I can't think of another reason at this moment).
> Perhaps that is too far-fetched, and copy_toolchain_sysroot should be
> updated, but in any case it makes sense to line up.

I think it's a separate issue, because we're already using ld*.so*
today in pkg-toolchain-external.mk for TOOLCHAIN_EXTERNAL_LIBS, I'm
just moving it around.

However, I agree we should probably line up things. In which direction
do you think we should line up? I guess using ld*.so* in
copy_toolchain_sysroot should be fine.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list