[Buildroot] [PATCH 4/7 v4] tools: move size-stat-compare out of support/scripts/

Thomas De Schampheleire patrickdepinguin at gmail.com
Sat Jul 1 16:02:57 UTC 2017


Hi Yann,

2017-07-01 16:31 GMT+02:00 Yann E. MORIN <yann.morin.1998 at free.fr>:
> Move it to the top-level tools/ directory, so that it is easier to
> find for users.
>
> Add a legacy symlink for those users who already used them, so as
> not to break their habits.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
> Cc: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
> Cc: Arnout Vandecappelle <arnout at mind.be>
>
> ---
> Changes v3 -> v4:
>   - drop legacy symlink  (Arnout, Thomas)
> ---
>  tools/readme.txt                              | 6 ++++++
>  {support/scripts => tools}/size-stats-compare | 0
>  2 files changed, 6 insertions(+)
>  rename {support/scripts => tools}/size-stats-compare (100%)
>
> diff --git a/tools/readme.txt b/tools/readme.txt
> index fc1108fded..dd8a1d4494 100644
> --- a/tools/readme.txt
> +++ b/tools/readme.txt
> @@ -11,6 +11,12 @@ get-developpers
>      of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as
>      input, a package name or and architecture name.
>
> +size-stat-compare
> +    a script to compare the rootfs size between two differnt Buildroot

You must have missed my comment about 'differnt' -> 'different'

> +    configurations. This can be used to identify the size impact of
> +    a specific option, or of a set of specific options, or an update
> +    to a newer Buildroot version...

While you're at it, the last clause would either also need 'of': 'or
of an update...',
or otherwise it would need to be removed on the second clause, but now
it is inconsistent.

Thanks,
Thomas


More information about the buildroot mailing list