[Buildroot] [PATCH] Makefile: don't run "menuconfig" automatically

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Jul 1 08:26:22 UTC 2017


Hello,

On Sat, 1 Jul 2017 10:24:46 +0200, Arnout Vandecappelle
(Essensium/Mind) wrote:
> Since forever, we run 'menuconfig' automatically on an unconfigured
> tree. However, this does not help users that much:
> - If they read the documentation, they should already know to run
>   make menuconfig first.
> - If they haven't read the documentation, dropping them in menuconfig
>   isn't very helpful.
> - It's a likely that the user didn't intend to be in an unconfigured
>   tree (e.g. wrong O= specified), so starting menuconfig (and polluting
>   this wrong O= directory) is not very helpful.
> - It's possible that the user really doesn't want menuconfig, but
>   instead needs xconfig, or some defconfig, or ...
> 
> So, instead of trying to guess what the user needs, print an error and
> let the user decide what to do next.
> 
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout at mind.be>
> ---
>  Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com


More information about the buildroot mailing list