[Buildroot] [PATCH 4/4] bctoolbox: disable rpath

[Thomas Petazzoni]

Hello,

On Sun, 19 Feb 2017 16:07:35 +0100, Jörg Krause wrote:

> > Worth mentioning that there is both CMAKE_SKIP_RPATH and
> > CMAKE_SKIP_INSTALL_RPATH. The former skips adding the rpath during
> > both
> > the build and install steps, which prevents from running the binary
> > from the build directory. The latter only skips the rpath during the
> > install step. But since we're cross-compiling, running on the host
> > machine from the build directory anyway doesn't make sense. So
> > CMAKE_SKIP_RPATH is OK.
> > 
> > See https://cmake.org/cmake/help/v3.0/variable/CMAKE_SKIP_RPATH.html.  
> 
> Samuel argues not to force this option by the infrastructure. I am 	
> not sure how do we handle this properly. So, what shall we do?

As I said in my second e-mail (sent after reading Samuel's answer),
Samuel is probably correct. Skipping the rpath in *all* cases may not
be correct, so we have to do it at the per-package level, like your
patch does.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com