[Buildroot] [PATCH v3 01/38] package/libdvdcss: add Kodi-specific patches

[Thomas Petazzoni]

Hello,

On Sat, 11 Feb 2017 17:03:42 +0100, Bernd Kuhls wrote:

> > Are these .a files still needed after the switch to CMake as the build
> > system for Kodi?  
> 
> fortunately no.

Good.

> > Also, for the patches that apply to the libdvdcss, libdvdread and
> > libdvdnav code base, it would be good to know if they have been
> > submitted to the respective upstream projects, or if it's stuff that we
> > may have to keep in Buildroot forever.  
> 
> Afaics when using the new CMake-based build system of Kodi 17 it will
> build libdvd* itself by using Kodi-specific tarballs:
> 
> https://github.com/xbmc/xbmc/blob/Krypton/project/cmake/modules/FindLibDvd.
> cmake#L100
> https://github.com/xbmc/xbmc/blob/Krypton/project/cmake/modules/FindLibDvd.
> cmake#L132
> https://github.com/xbmc/xbmc/blob/Krypton/project/cmake/modules/FindLibDvd.
> cmake#L164
> 
> So we do neither need to patch libdvd* anymore nor provide them as 
> dependent packages, KODI_EXTRA_DOWNLOADS can be used to provide the 
> tarballs.

Except that we definitely don't want this thing. Kodi should use the
libdvd* libraries built by Buildroot. Not download/build its own.

> First build tests were successful but I would like to be cautious about the 
> switch to CMake because I only started to use it today with an x86_64 
> toolchain so I have not much experience with it, as of this moment I never 
> did a runtime test of the compiled binaries. I hope to find some time for 
> this in the coming days but until then you can find my patches here:
> 
> https://github.com/bkuhls/buildroot/tree/kodi_cmake
> 
> Please note that LibreElec and Gentoo already build Kodi 17 using CMake:
> 
> https://github.com/LibreELEC/LibreELEC.tv/blob/libreelec-
> 8.0/packages/mediacenter/kodi/package.mk#L34
> 
> https://gitweb.gentoo.org/repo/gentoo.git/tree/media-tv/kodi/kodi-
> 17.0.ebuild#n161

I leave it up to you when it is a good time to switch to the CMake
based build system.

> Do we still have external toolchains based on uClibc 0.9.33.2?
> If yes, we need to keep 
> https://git.buildroot.net/buildroot/tree/package/kodi/0003-ALSA-fix-device-
> change-event-support.patch and add CMake checks for eventfd_read & 
> eventfd_write.

No, we don't care about uClibc 0.9.33.2 anymore. The only external
toolchain that was using an old uClibc version was the Analog Devices
Blackfin toolchain, and we got rid of it during the last cycle.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com