[Buildroot] [PATCH 1/4] support/scripts: add script to test a package

[Thomas De Schampheleire]

On Tue, Feb 7, 2017 at 4:18 PM, Luca Ceresoli <lucaceresoli77 at gmail.com> wrote:
> Hi,
>
> On 07/02/2017 14:52, Yann E. MORIN wrote:
>> This script helps in testing that a pacakge builds fine on a wide range
>> of architectures and toolchains: BE/LE, 32/64-bit, musl/glibc/uclibc...
>>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni at free-electrons.com>
>> [yann.morin.1998 at free.fr:
>>  - completely rewrite the script from Thomas, with help from Luca
>> ]
>> Signed-off-by: "Yann E. MORIN" <yann.morin.1998 at free.fr>
>> Cc: Luca Ceresoli <luca at lucaceresoli.net>
>> Cc: Thomas De Schampheleire <patrickdepinguin at gmail.com>
>
> Just two very minor nits about wording. For the rest the diff from the
> version I already reviewed is very limited anyway.
>
> [...]
>
>> +help() {
>> +    cat <<_EOF_
>> +test-pkg: test-build a package against various toolchains and architectures
>> +
>> +The supplied config snippet is appended to each toolchain config, the
>> +resulting configuration is checked that it still contains all options
>
> "is checked that it still contains" seems wrong to me.
> I'd reword it as "is checked to ensure it still contains".
>
>> +specified in the snippet; if any is missing, the build is skipped, on the
>> +assumption that the package under test requires a toolchain or architecture
>> +feature that is missing.
>> +
>> +The list of toolchains is retrieved from Buildroot autobuilders, available
>
> from Buildroot autobuilders -> from the Buildroot autobuilders
>
> With these fixed:
> Acked-by: Luca Ceresoli <luca at lucaceresoli.net>
>


With suggestions from Luca fixed:
Reviewed-by: Thomas De Schampheleire <thomas.de_schampheleire at nokia.com>