[Buildroot] [PATCH 9/9] check-package: check *.mk for typo in variable

Ricardo Martincoski ricardo.martincoski at gmail.com
Tue Feb 7 00:33:34 UTC 2017


Romain,

On Sat, Jan 21, 2017 at 03:19 PM, Romain Naour wrote:

> Le 31/12/2016 à 04:21, Ricardo Martincoski a écrit :

[snip]

> This one produce a false positive with MYSQL_SOCKET from oracle-mysql because
> it's a virtual package providing mysql:
> 
> package/oracle-mysql/oracle-mysql.mk:19: possible typo: MYSQL_SOCKET ->
> *ORACLE_MYSQL*
> 
> MYSQL_SOCKET = /run/mysql/mysql.sock

The easy way is to just add MYSQL_SOCKET to the ALLOWED regex ...

> 
> ORACLE_MYSQL_PROVIDES = mysql
> 
> Maybe we could add an exception for variables named <<provider_name>_PROVIDES>_* ?

... but I will try this generic approach, probably in a similar way I did for
the LINUX_TOOL_ prefix. It sounds more correct.

> 
> MYSQL_SOCKET is used in mariadb and php packages.
> 
> Other warnings (15) are real real typo or variable without the right package prefix.

Thank you for your review.
Sorry the delay.

Best regards,
Ricardo


More information about the buildroot mailing list