[Buildroot] [PATCH v6 8/9] python-pyqt5: Depend directly on Qt5 rather than its toolchain requirements

Arnout Vandecappelle arnout at mind.be
Thu Feb 2 23:06:59 UTC 2017



On 31-01-17 08:59, Zoltan Gyarmati wrote:
> From: Naumann Andreas <ANaumann at ultratronik.de>
> 
>  When pyqt5 is used it's obvious that qt5 needs to be selected and configured
> by the user, hence we enforce it by making pyqt5 depending on qt5, rather than
> selecting it and depending only on the qt5 requirements.

 I'm not so sure that this really is an improvement. Andreas, can you explain
why this is needed?

 Regards,
 Arnout

> 
> Signed-off-by: Andreas Naumann <anaumann at ultratronik.de>
> Signed-off-by: Zoltan Gyarmati <mr.zoltan.gyarmati at gmail.com>
> ---
>  package/python-pyqt5/Config.in | 13 +++----------
>  1 file changed, 3 insertions(+), 10 deletions(-)
> 
> diff --git a/package/python-pyqt5/Config.in b/package/python-pyqt5/Config.in
> index 4eca68a..20ac988 100644
> --- a/package/python-pyqt5/Config.in
> +++ b/package/python-pyqt5/Config.in
> @@ -1,16 +1,9 @@
> -comment "python-pyqt5 needs a toolchain w/ wchar, NPTL, C++, dynamic library"
> -	depends on !BR2_PACKAGE_QT
> -	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
> -		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
> +comment "python-pyqt5 needs Qt5"
> +	depends on !BR2_PACKAGE_QT5
>  
>  config BR2_PACKAGE_PYTHON_PYQT5
>  	bool "python-pyqt5"
> -	depends on BR2_INSTALL_LIBSTDCPP
> -	depends on BR2_USE_WCHAR # qt5
> -	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # qt5
> -	depends on !BR2_STATIC_LIBS # qt5
> -	depends on !BR2_PACKAGE_QT # qt5
> -	select BR2_PACKAGE_QT5
> +	depends on BR2_PACKAGE_QT5
>  	select BR2_PACKAGE_PYTHON_SIP
>  	help
>  	  Python bindings for Qt 5
> 

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list