[Buildroot] [PATCH v2 1/1] nginx: Harden patches for using pkg-config
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Dec 29 22:35:04 UTC 2017
Hello,
On Tue, 19 Dec 2017 13:59:04 +0100, Ignacy Gawędzki wrote:
> On Tue, Dec 19, 2017 at 01:43:16PM +0100, thus spake Thomas Petazzoni:
> > Hello,
> >
> > On Tue, 19 Dec 2017 11:10:24 +0100, Ignacy Gawędzki wrote:
> > > Don't simply remove "-I" from the output of pkg-config --cflags-only-I
> > > but match the -I argument more generally.
> >
> > OK, but why? What is this fixing?
>
> Suppose that the lib has been installed in /usr/Some-Install-Location/
> then pkg-config --cflags-only-I may return
>
> -I/usr/Some-Install-Location/include
>
> which, piped through sed 's/-I//g' would end up being
>
> /usr/Somenstall-Location/include
>
> which is probably not going to work.
Indeed, makes total sense. I've applied your patch, after rewording the
commit log to be clearer about what is being fixed. Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
More information about the buildroot
mailing list