[Buildroot] [PATCH v2 2/2] package/brltty: explicitly check if ioperm is available

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Dec 29 16:19:59 UTC 2017


Hello,

On Fri, 29 Dec 2017 15:06:41 +0100, Mario Lang wrote:

> +diff --git a/configure.ac b/configure.ac
> +index 5e94d33bd..07119dd9f 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -1446,7 +1446,9 @@ BRLTTY_ARG_PACKAGE([ports], [I/O ports], [], [dnl
> +       ports_package="kfreebsd"
> +       ;;
> +    linux*)
> +-      ports_package="glibc"
> ++      AC_CHECK_FUNC([ioperm], [
> ++         ports_package="glibc"

This seems weird. What happens then when ioperm() is not available ?
Which ports_package is used ?


> -BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES)
> +BRLTTY_DEPENDENCIES = $(TARGET_NLS_DEPENDENCIES) host-autoconf
>  
>  BRLTTY_CONF_OPTS = \
>  	--disable-java-bindings \
> @@ -24,6 +24,12 @@ BRLTTY_CONF_OPTS = \
>  	--without-mikropuhe --without-speechd --without-swift \
>  	--without-theta --without-viavoice
>  
> +define BRLTTY_AUTOCONF
> +	cd $(BRLTTY_SRCDIR) && $(AUTOCONF)
> +endef
> +
> +BRLTTY_PRE_CONFIGURE_HOOKS += BRLTTY_AUTOCONF

Please use BRLTTY_AUTORECONF = YES instead.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list