[Buildroot] [PATCH] utils/checkpackagelib: exclude two files from Config.in indentation check

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Dec 20 08:10:53 UTC 2017


Hello,

On Tue, 19 Dec 2017 21:32:04 -0200, Ricardo Martincoski wrote:

> Thank you for explaining (in the other e-mail) the reasoning of the special
> indentation.
> 
> 
> One last thought about the code...
> 
> Until now the script can be called passing relative or absolute filenames to
> check. These 3 commands have the same result:
> $ ./utils/check-package $(find $(readlink -f package) -type f) >/dev/null
> $ ./utils/check-package $(find package -type f) >/dev/null
> $ ./utils/check-package $(find ./package -type f) >/dev/null
> 
> To keep this behavior we could use instead:
>                 if self.filename.endswith("package/x11r7/Config.in") or \
>                    self.filename.endswith("package/kodi/Config.in"):
> or its equivalent in one line (it fits in 132).

Sure, makes sense.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list