[Buildroot] [PATCH] traceroute: new package

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Sat Dec 16 15:06:36 UTC 2017


Hello,

On Sat, 16 Dec 2017 11:01:49 -0200, Sergio Prado wrote:

> +define TRACEROUTE_INSTALL_TARGET_CMDS
> +	$(RM) -f $(TARGET_DIR)/usr/bin/traceroute

I didn't see why this is needed. The package does a simple "cp", so
reinstallation works fine. So I've dropped this.

> +	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> +		prefix=$(TARGET_DIR)/usr install -C $(@D)

This value of prefix is not really correct. A more correct approach is
DESTDIR=$(TARGET_DIR) prefix=/usr. Even though it changes nothing in
practice for this package, it is more consistent with what we do in
other packages (and what is technically correct).

Applied with those changes. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list