[Buildroot] [PATCH] lua: refactor with a common template lua.pc.in

[François Perrad]

2017-08-20 14:15 GMT+02:00 Thomas Petazzoni <
thomas.petazzoni at free-electrons.com>:

> Hello,
>
> On Sun, 20 Aug 2017 10:38:56 +0200, Francois Perrad wrote:
>
> > +define LUA_CONFIGURE_CMDS
> > +     sed -e "s/@VERSION@/$(LUA_VERSION)/;s/@ABI@/$(LUAINTERPRETER_
> ABIVER)/;s/@MYLIBS@/$(LUA_MYLIBS)/" \
> > +             package/lua/lua.pc.in > $(@D)/lua.pc
> > +endef
> > +
> > +define HOST_LUA_CONFIGURE_CMDS
> > +     sed -e "s/@VERSION@/$(LUA_VERSION)/;s/@ABI@/$(LUAINTERPRETER_
> ABIVER)/;s/@MYLIBS@/$(HOST_LUA_MYLIBS)/" \
> > +             package/lua/lua.pc.in > $(@D)/lua.pc
> > +endef
>
> I still disagree, and still believe that it should be done as part of
> the <pkg>_BUILD_CMDS step.
>
> Also, could you clarify if you intend this patch to be merged in the
> master branch or in the next branch.
>

It is not a fix, just an improvement of the recent  Jorg Krause's work
which was never released.
That saids master branch could be prefered.

François.


>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170821/3aa68926/attachment.html>