[Buildroot] [PATCH 1/2] package/monolite: bump to version 1050001000

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Aug 11 18:31:34 UTC 2017


Hello,

On Fri, 11 Aug 2017 17:07:18 +0200, Angelo Compagnucci wrote:

> >> Sorry for the noise, but this is not how the things worked in the
> >> past. I was suggested several times in the past to send a patch for
> >> each modification/package.  
> >
> >  Yes, but only if they indeed work separately. Don't worry, I'll squash while
> > applying.  
> 
> I searched the history for the mono package just to be sure and such a
> way of squashing commits for separate packages was never been done.
> I'm a bit puzzled ...

Yes, I used to apply them separately. Theoretically, if the bumps are
really both needed for the whole thing to work, Arnout is right that
both bumps should be done in the same patch.

I simply don't apply an absolutely strict rule of "everything should be
bisectable" in Buildroot, so I'm a bit more relaxed than Arnout on
this. I'm not saying Arnout isn't right, just that it wasn't something
that I thought was important enough.

> Right now I'm working updating sysdig and it requires som bumps to
> other packages, should I send a squashed patch?!

No, because the patch series is bisectable: if we apply only PATCH 1/3,
it works. If we apply patches 1/3 and 2/3, it works. And if we apply
1/3, 2/3 and 3/3, it works.

The question is not whether patches are independent, but whether the
patch series is bisectable. I.e what happens if you apply only M
patches on the total of N patches in the series.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list