[Buildroot] [PATCH v3] libcgi: bump to version 1.1

xlcwu xlcwu.taiwan at gmail.com
Fri Aug 11 05:47:39 UTC 2017


Hi Arnout,

On Thu, Aug 10, 2017 at 7:48 PM, xlcwu <xlcwu.taiwan at gmail.com> wrote:
> Hi Arnout
>
> I build the libcgi by follow steps in
> https://github.com/rafaelsteil/libcgi/blob/master/README.md
>
>
> On Thu, Aug 10, 2017 at 4:20 PM Arnout Vandecappelle <arnout at mind.be> wrote:
>>
>>  Hi Joe,
>>
>> On 10-08-17 09:45, Joe Lin wrote:
>> > Cleanup the libcgi package,
>> > by using https://github.com/rafaelsteil/libcgi as an upstream.
>> > Remove old patch and use cmake to build new version.
>> >
>> > Signed-off-by: Joe Lin <xlcwu.taiwan at gmail.com>
>> [snip]
>> > -LIBCGI_VERSION = 1.0
>> > -LIBCGI_SITE =
>> > http://downloads.sourceforge.net/project/libcgi/libcgi/$(LIBCGI_VERSION)
>> > +LIBCGI_VERSION = 1.1
>> > +LIBCGI_SITE =
>> > https://github.com/rafaelsteil/libcgi/releases/download/v$(LIBCGI_VERSION)
>> > +
>> >  LIBCGI_INSTALL_STAGING = YES
>> > -# use cross CC/AR rather than host
>> > -LIBCGI_MAKE_ENV = CC="$(TARGET_CC) $(TARGET_CFLAGS)" AR="$(TARGET_AR)"
>> > \
>> > -     $(if $(BR2_STATIC_LIBS),STATIC=1)
>> >  LIBCGI_LICENSE = LGPL-2.1+
>> >
>> > -$(eval $(autotools-package))
>> > +LIBCGI_SUPPORTS_IN_SOURCE_BUILD = NO
>>
>>  Mario (added in Cc) submitted a similar patch and it didn't have this
>> _IN_SOURCE_BUILD line. Is it really needed?
>
> I am not sure and I will trigger a build to check it.
I build libcgi with/without _IN_SOURCE_BUILD = NO then use "diff -y"
"cmp -l" to compare two binary and make no difference. We can remove
it.

>>
>>
>>  Regards,
>>  Arnout
>>
>> > +
>> > +$(eval $(cmake-package))
>> >
>>
>> --
>> Arnout Vandecappelle                          arnout at mind be
>> Senior Embedded Software Architect            +32-16-286500
>> Essensium/Mind                                http://www.mind.be
>> G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
>> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
>> GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF


More information about the buildroot mailing list