[Buildroot] [PATCH v3] atest: new package

Baruch Siach baruch at tkos.co.il
Fri Apr 14 05:50:02 UTC 2017


Hi Fabio,

On Thu, Apr 13, 2017 at 08:14:56PM -0300, Fabio Estevam wrote:
> On Thu, Apr 13, 2017 at 5:48 PM, Thomas Petazzoni
> <thomas.petazzoni at free-electrons.com> wrote:
> 
> > A Config.in comment was missing here to show the glibc/musl+thread
> > dependency, so I've added that.
> 
> I see you added:
> 
> +comment "atest needs a glibc or musl toolchain w/ threads"
> + depends on !BR2_bfin
> + depends on BR2_TOOLCHAIN_USES_UCLIBC || !BR2_TOOLCHAIN_HAS_THREADS
> 
> ,but this should be:
> 
> depends on !BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_HAS_THREADS

We want the comment to appear when the packages can't build because of 
toolchain properties. So the committed dependency looks correct. That is, the 
comment appears when the toolchain uses uClibc or doesn't support threads.

The !BR2_bfin dependency is there to hide the comment when the architecture is 
incompatible. The comment will be misleading (changing toolchain won't help), 
and the user can't change the architecture selection in most cases.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -


More information about the buildroot mailing list