[Buildroot] CMAKE_SYSROOT issue [was: Re: [PATCH] toolchain-external: fix potential entire root filesystem removal]

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998 at free.fr> writes:

Hi,

>> >> [02/09 11:17:31] <smartin> cmake seems to split it like this:
 >> >> '--sysroot <STAGING_DIR> -I/urs/include' , i guess cmake does it
 >> >> because of/based on the CMAKE_SYSROOT.
 >> >> [02/09 11:17:57] <smartin> ^^^ is to be confirm with cmake developers
 >> >> [02/09 11:18:45] <smartin> but i wonder why it keep '-I/usr/include'
 >> >> since it is a standard location that gcc will check anyway
 >> >> [02/09 11:19:02] <smartin> ^^^ also, to be figured out with cmake developers
 >> 
 >> Samuel, did you hear back from the cmake devs?

 >> From what I recal, there was no issue with our cmake infra as it is now.

 > The problem lies in websocketpp's CMakeList.txt which is incorrect and
 > forcefully adds /usr/include.

 > I even sent a PR upstream to fix the issue:

 >     https://github.com/zaphoyd/websocketpp/pull/578

 > Unfortunately, it seems the websocketpp hasn't had any activity since
 > last February: no commit, no PR review, no comment on issues...

 > But there is now a patch that Pieter can use when he submits
 > websocketpp.

 > So, after discussing the issue on IRC with Samuel, I believe this is a
 > non-issue in our infra.

Ok, good to hear - Thanks!

-- 
Venlig hilsen,
Peter Korsgaard