[Buildroot] [PATCH] package/nginx-naxsi: add pcre dependency to .mk

Peter Korsgaard peter at korsgaard.com
Sat Sep 17 10:11:12 UTC 2016


>>>>> "Samuel" == Samuel Martin <s.martin49 at gmail.com> writes:

Hi,

 >> Is this really necessary? nginx-naxsi is not a real package, it just
 >> allows to download the source code of nginx-naxsi before nginx gets
 >> built.
 >> 
 >> And nginx.mk already has pcre in NGINX_DEPENDENCIES when pcre is
 >> enabled, so I believe the select added in
 >> 218dfdd9038af882a02fe64f13a533c8ce75ddc1 is sufficient.

 > I agree, hence the first patch...

 >> 
 >> If not, could you explain why?

 > ... but Arnout does not seem to share this opinion [1].

 > So, I'm tempted to said "maintainer call" on this.

 > [1] http://lists.busybox.net/pipermail/buildroot/2016-September/172113.html

I instead added a comment above the select to clarify and marked this
patch as superseeded in patchwork.

-- 
Bye, Peter Korsgaard


More information about the buildroot mailing list