[Buildroot] [PATCH] toolchain-external: fix potential entire root filesystem removal
Peter Korsgaard
peter at korsgaard.com
Thu Sep 15 10:04:03 UTC 2016
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni at free-electrons.com> writes:
> This reverts commit a0aa7e0e1750f6ace2879ea8adb1425a41431b79 and reworks
> the code to fix a major and potentially catastrophic bug when the
> following conditions are met:
> - The user has selected a "known toolchain profile", such as a Linaro
> toolchain, a Sourcery CodeBench toolchain etc. People using "custom
> toolchain profile" are not affected.
> - The user has enabled BR2_TOOLCHAIN_EXTERNAL_PREINSTALLED=y to
> indicate that the toolchain is already locally available (as
> opposed to having Buildroot download and extract the toolchain)
> - The user has left BR2_TOOLCHAIN_EXTERNAL_PATH empty, because his
> toolchain is directly available through the PATH environment
> variable. When BR2_TOOLCHAIN_EXTERNAL_PATH is non-empty, Buildroot
> will do something silly (remove the toolchain contents), but that
> are limited to the toolchain itself.
> When such conditions are met, Buildroot will run "rm -rf /*" due to
> TOOLCHAIN_EXTERNAL_INSTALL_DIR being empty.
> This bug does not exist in 2016.05, and appeared in 2016.08 due to
> commit a0aa7e0e1750f6ace2879ea8adb1425a41431b79.
Gaah - Committed, thanks!
I'll put out a 2016.08.1 release with this Saturday or Sunday. Anything
else that should be included in this bugfix release?
--
Bye, Peter Korsgaard
More information about the buildroot
mailing list