[Buildroot] [PATCH] package/nginx-naxsi: add pcre dependency to .mk

[Thomas Petazzoni]

Hello,

On Tue, 13 Sep 2016 20:01:02 +0200, Samuel Martin wrote:
> This change completes the commit 218dfdd9038af882a02fe64f13a533c8ce75ddc1.
> 
> Signed-off-by: Samuel Martin <s.martin49 at gmail.com>
> ---
>  package/nginx-naxsi/nginx-naxsi.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/nginx-naxsi/nginx-naxsi.mk b/package/nginx-naxsi/nginx-naxsi.mk
> index 0e1f714..ad7749e 100644
> --- a/package/nginx-naxsi/nginx-naxsi.mk
> +++ b/package/nginx-naxsi/nginx-naxsi.mk
> @@ -8,5 +8,6 @@ NGINX_NAXSI_VERSION = 0.54
>  NGINX_NAXSI_SITE = $(call github,nbs-system,naxsi,$(NGINX_NAXSI_VERSION))
>  NGINX_NAXSI_LICENSE = GPLv2+ with OpenSSL exception
>  NGINX_NAXSI_LICENSE_FILES = naxsi_src/naxsi_json.c
> +NGINX_NAXSI_DEPENDENCIES = pcre
>  
>  $(eval $(generic-package))

Is this really necessary? nginx-naxsi is not a real package, it just
allows to download the source code of nginx-naxsi before nginx gets
built.

And nginx.mk already has pcre in NGINX_DEPENDENCIES when pcre is
enabled, so I believe the select added in
218dfdd9038af882a02fe64f13a533c8ce75ddc1 is sufficient.

If not, could you explain why?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com