[Buildroot] [PATCH] add new library: libpugixml

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Fri Sep 9 12:14:11 UTC 2016


Hello,

On Tue, 6 Sep 2016 14:07:39 +0200, Theo Debrouwere wrote:

> > The readme.txt is good enough as a license file.
> >   
> > > +LIBPUGIXML_INSTALL_STAGING = YES
> > > +
> > > +LIBPUGIXML_SUBDIR = scripts  
> > 
> > Hum, why?  
> 
> Is this about the SUBDIR option?
> 
> The CMakeLists.txt file is in a subfolder called scripts,
> so, it seems that I need this? Is there another option/setting?
> 
> Or should I add a comment about it?
> 
> I'm not sure what you are asking?

What confused me is that in the latest version of pugixml (i.e master
branch), the CMakeLists.txt is directly at the root of the project:

  https://github.com/zeux/pugixml

However, since you are packaging the 1.7 version, which is a bit older
than the master branch, the CMakeLists.txt is indeed inside the
scripts/ subdirectory:

  https://github.com/zeux/pugixml/tree/v1.7

So, it makes complete sense to use the SUBDIR option in this case. It's
just that I was confused when looking at the Github repository, as I
was looking at the master branch.

Thanks for your contribution!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list