[Buildroot] [PATCH v2,1/1] gtest: retrieve package from github

Thomas Petazzoni thomas.petazzoni at free-electrons.com
Wed Sep 7 14:31:23 UTC 2016


Hello,

On Wed, 7 Sep 2016 11:24:15 -0300 (BRT), Carlos Santos wrote:

> > I guess moving to using the CMake based build system would make more
> > sense, but that's a bigger task.
> > 
> > Patches welcome :)  
> 
> A patch was sent a long time ago, but was rejected[1]. I will update it and resubmit for review.
> 
> 1. http://patchwork.ozlabs.org/patch/586130/

Well, the patch says:

"""
2) There is no tag corresponding to gmock 1.7.0. We circumvent this by
   refering to the commit id corresponding to gmock 1.7.0.
"""

But this is not really true, in the
https://github.com/google/googlemock/ repository, you do have the older
1.7.0.

Also, your patch was using the autotools build process for gmock, which
caused problems with ax_pthread.m4. Isn't switching to the CMake build
process a better idea here, since gtest is anyway already using CMake ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


More information about the buildroot mailing list