[Buildroot] [PATCH 1/1] package/opencv3: use BR2_TOOLCHAIN_HAS_LIBATOMIC

Samuel Martin s.martin49 at gmail.com
Mon Sep 5 21:40:20 UTC 2016


On Mon, Sep 5, 2016 at 11:25 PM, Thomas Petazzoni
<thomas.petazzoni at free-electrons.com> wrote:
> Hello,
>
> On Mon, 5 Sep 2016 23:20:00 +0200, Samuel Martin wrote:
>
>> > +# Uses __atomic_fetch_add_4
>> > +ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
>> > +OPENCV3_CONF_OPTS += -DCMAKE_CXX_FLAGS="-latomic"
>> > +endif
>>
>> Since you add the dependency on BR2_TOOLCHAIN_HAS_ATOMIC in the
>> Config.in, I wonder whether nested conf. opts. update in a if-block
>> that will always be true is really necessary...
>
> You're confusing BR2_TOOLCHAIN_HAS_ATOMIC with
> BR2_TOOLCHAIN_HAS_LIBATOMIC. There's a subtle difference :)
>
gah! Right :-/

> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com



-- 
Samuel


More information about the buildroot mailing list